The skill node has 3 effects, one for daggers (extra crit chance), one for swords (bleed chance), and one for two handed swords (extra crit multi).
The one for swords and two handed swords works fine, the one for daggers doesn’t work at all. No change to damage tooltip, and when you get +4% base crit on a skill I’d expect to see a significant change in a crit based build.
Extra: The “Steelshaper Grit” node right next to it, that also gives Critical Chance, ALSO doesn’t work. When comparing with other skills that have similar effects, like Shadow Cascade, the problem seems to be the fact that Bladestorm doesn’t say “BASE critical STRIKE chance” (when it clearly means that as the bonuses are the same), unlike the other two that do have that text AND the tooltip changes as you put points in the skills.
If this is a coding 101 issue, I’d assume the problem is that those nodes are looking for the “critical chance” stat and it simply doesn’t exist, as it’s either Critical Strike Chance or Base Critical Strike Chance.